Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove qed input from ekobox.apply.apply_pdf #1841

Merged
merged 3 commits into from
Nov 14, 2023
Merged

remove qed input from ekobox.apply.apply_pdf #1841

merged 3 commits into from
Nov 14, 2023

Conversation

RoyStegeman
Copy link
Member

@RoyStegeman RoyStegeman commented Nov 14, 2023 •
edited
Loading

This input was removed from the function in eko

@niclaurenti
Copy link
Contributor

Now this line

nnpdf/n3fit/src/evolven3fit_new/evolve.py

Line 101 in d2b942b

qed = theory.order[1] > 0

can be removed.
And also qed from

nnpdf/n3fit/src/evolven3fit_new/evolve.py

Line 115 in d2b942b

evolved_blocks = evolve_exportgrid(pdf_data, eko_op, x_grid, qed)

and

nnpdf/n3fit/src/evolven3fit_new/evolve.py

Line 148 in d2b942b

def evolve_exportgrid(exportgrid, eko, x_grid, qed):

@felixhekhorn
Copy link
Contributor

for the test to succeed you need to update the eko version of course - actually in conda I believe ... maybe @scarlehoff can give a hand?

@RoyStegeman
Copy link
Member Author

RoyStegeman commented Nov 14, 2023 •
edited
Loading

I think in eko 0.13.5 the function had a default input, so I'm not sure any test would fail. Either way, you're right that now the tag is there we want to update the nnpdf dependency, though for this we'll have to wait for the conda bot to open the PR (or maybe there's a way to force it manually, but I believe the bot should be pretty quick as well)

@RoyStegeman RoyStegeman merged commit 90be1cd into master Nov 14, 2023
4 checks passed
@RoyStegeman RoyStegeman deleted the hotfix_apply_pdf branch November 14, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niclaurenti niclaurenti niclaurenti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RoyStegeman @niclaurenti @felixhekhorn